[1.3.3087] Incorrect mood information for a precept

Started by llunak, August 16, 2021, 06:51:02 AM

Previous topic - Next topic

llunak

In the ideoligion screen, tooltips for some precepts show incorrect mood information. For example, "Drug use Essential" shows "Drugs taken every 0.75 days: +3", but it really should show "Drugs taken every 0.75 days (min expectation: Low): -10 to +3".

Part of the problem is in PreceptComp_Thought.ParseDescription(), which in the !flag case checks only the first thought, not all of them (drug use has the fist one positive).
The other part of the problem is that the HighLife thought in Precepts_HighLife.xml needs to have all stages explicitly list <baseMoodEffect>, and the thought usage in the precept needs to have tooltipShowMoodRange set to true, as these two are used by PreceptComp_Thought.ParseDescription() to construct the tooltip.

It is possible that some other tooltips are affected as well.

Pheanox

Thanks for the bug report.  I've written in your suggestion via code for review, and either way the devs should address the inconsistency.