Ludeon Forums

RimWorld => Bugs => Topic started by: hpram99 on February 27, 2020, 12:59:45 PM

Title: [1.1] Completing trade quest does not give any trade items
Post by: hpram99 on February 27, 2020, 12:59:45 PM
Quest debug info, as well as trace for error generated when "completing" the quest normally are below.
-Faction relation increases
-Items are removed from inventory
-None of the trade items are received back

-----------------
Id: 2
State: Ongoing
Data:
<saveable Class="Quest">
  <id>2</id>
  <name>Unnamed quest</name>
  <appearanceTick>14021888</appearanceTick>
  <acceptanceTick>14021888</acceptanceTick>
  <acceptedBy>null</acceptedBy>
  <initiallyAccepted>True</initiallyAccepted>
  <challengeRating>-1</challengeRating>
  <description>A nearby settlement, White Creek, contacts you with a special trade request. They would like to purchase:

  Lightleather x1980 (worth $3762)

In return, they offer:

  Advanced component x25 and hyperweave x75 (worth $5675)

This request expires after: 24 days

If you want to make the trade, send a caravan with the requested supplies. The estimated travel time is 4.2 days. You can review this offer by selecting White Creek on the world map.</description>
  <signalsReceivedDebug IsNull="True" />
  <parts>
    <li Class="QuestPart_NoWorldObject">
      <inSignalEnable>Quest2.Initiate</inSignalEnable>
      <state>Enabled</state>
      <enableTick>14021888</enableTick>
      <worldObject>WorldObject_23</worldObject>
    </li>
    <li Class="QuestPart_QuestEnd">
      <inSignal>Quest2.Part0.Completed</inSignal>
      <outcome>Unknown</outcome>
    </li>
    <li Class="QuestPart_NoWorldObject">
      <inSignalEnable>Quest2.TradeRequestSite.TradeRequestFulfilled</inSignalEnable>
      <worldObject>null</worldObject>
    </li>
    <li Class="QuestPart_QuestEnd">
      <inSignal>Quest2.Part2.Completed</inSignal>
      <outcome>Success</outcome>
    </li>
  </parts>
  <tags />
</saveable>

Active QuestParts:
QuestPart_NoWorldObject (index=0)

------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------

RimWorld 1.1.2557 rev484
Verse.Log:Message(String, Boolean)
RimWorld.VersionControl:LogVersionNumber()
Verse.Root:CheckGlobalInit()
Verse.Root:Start()
Verse.Root_Entry:Start()

Loading game from file Quest Bug with mods:
  - Ludeon.RimWorld
Verse.Log:Message(String, Boolean)
Verse.SavedGameLoaderNow:LoadGameFromSaveFileNow(String)
Verse.<>c:<Start>b__1_1()
Verse.LongEventHandler:RunEventFromAnotherThread(Action)
Verse.<>c:<UpdateCurrentAsynchronousEvent>b__27_0()
System.Threading.ThreadHelper:ThreadStart_Context(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object)
System.Threading.ThreadHelper:ThreadStart()

Exception ticking QuestPart: System.NullReferenceException: Object reference not set to an instance of an object
  at RimWorld.QuestPartActivable.Complete (RimWorld.SignalArgs signalArgs) [0x00093] in <a12d1ce36500429788a966a010bef562>:0
  at RimWorld.QuestPartActivable.Complete () [0x00000] in <a12d1ce36500429788a966a010bef562>:0
  at RimWorld.QuestPart_NoWorldObject.QuestPartTick () [0x0001b] in <a12d1ce36500429788a966a010bef562>:0
  at RimWorld.Quest.QuestTick () [0x0008f] in <a12d1ce36500429788a966a010bef562>:0
Verse.Log:Error(String, Boolean)
RimWorld.Quest:QuestTick()
RimWorld.QuestManager:QuestManagerTick()
Verse.TickManager:DoSingleTick()
Verse.TickManager:TickManagerUpdate()
Verse.Game:UpdatePlay()
Verse.Root_Play:Update()
Title: Re: [1.1] Completing trade quest does not give any trade items
Post by: hpram99 on February 27, 2020, 01:02:26 PM
Savegame file here: https://www95.zippyshare.com/v/KHseODIz/file.html
Select the caravan and complete the trade agreement.
Title: Re: [1.1] Completing trade quest does not give any trade items
Post by: Cynapse on February 28, 2020, 02:13:30 AM
I see that many of the quests in your save are named "Unnamed quest" and have no description or no hyperlinks. Do the quests show up like that?
Title: Re: [1.1] Completing trade quest does not give any trade items
Post by: hpram99 on February 28, 2020, 11:09:20 AM
They do indeed.  I believe they were all the active/available quests from 1.0.
Now that 1.1 rolled out to me, they all appear as Unnamed quest in the new Quests window -Including the original ship quest from day 1.

New 1.1 issued quests have names though.  I assumed this was normal behavior since 1.0 didn't have the Quests window.
Title: Re: [1.1] Completing trade quest does not give any trade items
Post by: Cynapse on February 28, 2020, 11:28:38 AM
Did you get that quest pre-1.1? It may be a bug with back compatibility if that's the case.

Edit: fixed for next release. It was a back compatibility bug.