Ludeon Forums

RimWorld => General Discussion => Topic started by: atewithouttabIe on November 19, 2019, 04:10:09 AM

Title: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 19, 2019, 04:10:09 AM
Is there a reason for including Redshell / treasuredata in said Mod other than being nosey / user data collection btw?
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 19, 2019, 09:53:20 AM
Where did you see this? I only did a precursory scan of the source files, referenced assemblies, etc. and saw nothing of it. There was some Steam promotion-related material, but I didn't notice anything regarding data mining for hardware, etc.

That said, if it is included and not prominently conveyed to the user and/or only enabled via agreement, it would be an ethical issue among the FOSS community.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Canute on November 19, 2019, 10:18:04 AM
At first you should include any proof's at your posting, or it would be the same as when i say "atewithouttabIe is definitiv eating all the time on a table on a chair !". :-)
If you can include a proof, next question, where did you got this mod. Steam,forum provided link or 3.party website.

Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Pangaea on November 19, 2019, 10:41:04 AM
There is a warning of sorts about some type of "phoning home". How much is sent I don't know, but based on the OP it sounds like it may be more than advertised?

QuoteAgreement: When you download and use this mod, you agree to the fact that my mods all connect to a central server to count anonymously how many times you start a game with them. No personal information is transferred in any way, no connection information is stored (the cloud I use does not expose this to me). The purpose is solely for keeping track of which mods are still used and which are popular (subscriptions don't show that).
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 19, 2019, 11:27:28 AM
Ech, take a network sniffer whatever, Fiddler etc doesnt matter as long as it can show connections by process et al - im using process hacker for this, have for years...and once Rimworld starts check open connections - Vanilla Rimworld w only "CORE" in mods, nothing - you put Achtung mod in and you get 3 connections under the Rimworld process ID - one changing adress presumably for the Cloud as  was said in the agreement - 2x  "in.treasuredata.com" connections....
And its the steam version considering the forum link has been closed / hidden for mere mortals
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 19, 2019, 11:43:41 AM
Quote from: atewithouttabIe on November 19, 2019, 11:27:28 AM
And its the steam version considering the forum link has been closed / hidden for mere mortals

Just look at the files it downloads in you mods folder, or use a website like http://steamworkshop.download (http://steamworkshop.download) to download them as a zip. The source code can be easily viewed with any decent IDE or decompiler if you feel the author uploaded alternative files to the Steam downloader, and would like to inquire into it. Its difficult to answer, as even portions of the actual Steam API being used within the project could be using such services, which cannot be seen in the project, and not technically being used by the actual mod.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 19, 2019, 11:48:28 AM
Hm, i should have mentioned i dont play the actual "Steam" version of Rimworld but the DRM free version, never liked Steam and only got the account way back in the day for Red Orchestra, the original one -  but some mods you just have to get via steam if only cos some mod authors prefer to do updates there exclusively, hence the Steam version of Achtung mod...once the mod is on HD it will be renamed properly cos "18799367" is a tad shit when trying to find whats what and checked whats in there, defs etcetc and put in the actual rimworld play / mod folder so...

Edit, i was wrong, i got the 2.3.3 version of Achtung not from Steam but github/releases directly - just saw that so my bad
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 19, 2019, 11:57:24 AM
It is just the outward folder name, the contents is exactly the same. I am running DRM-free version on Arch Linux, I understand the differences. Being a "Steam" version or "non-Steam" version does not change the contents, the same files are still present, the Steam Workshop is simply a cloud service that stores the files in the appropriate place, there is nothing different about it than manually downloading and copying the files yourself, renaming to whatever you want. I use the download service I linked above all the time to manually get the files from Steam to use in my "non-Steam" RimWorld when I can't find an alternative mirror.

That said, the XML files and defs are not going to be what to look at, it is just markup, the only thing you need to view is the assemblies.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 19, 2019, 02:09:14 PM
So what's the question about my mods, in particular Achtung? I was asked to respond to this thread but am unsure about what exactly.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 19, 2019, 02:13:16 PM
Doesn't appear to be anything. I think OP was mistaking the Steam methods you use as your mod "phoning home" and data mining of some sort.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Canute on November 19, 2019, 03:35:46 PM
I think the OP want to know.
Why does Rimworld open 3 connection with active Achtung mod, while without Achtung there arn't any connections ?
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 19, 2019, 03:52:18 PM
Each of my mods does a simple http request to a cloud server for every game started. The only payload is the mod name. As a result I have a global counter per mod that is incremented and reset every day so I get the number of games started per mod per day. Not by user but in total.

This can easily be verified with a network sniffer or by disassembling the mod to verify that the source code is in fact what was compiled. Here is the function in all its glory:

https://github.com/pardeike/Achtung2/blob/master/Source/ModCounter.cs
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 19, 2019, 06:20:26 PM
Since there seems to be some confusion about what i mean - here, screenshot - that is a completely vanilla Rimworld w just CORE and Achtung in Mods folder...
(https://i.ibb.co/MgJhdNh/yolo.jpg) (https://ibb.co/QJxc0mc)

The first Rimworld connection is a google address, corresponding w the brainz-central1 blabla cloud thing in modscounter.cs which is fine for what its worth

...the 2x "in.treasuredata.com" connections are more in line with this:
https://www.reddit.com/r/Steam/comments/8pud8b/psa_red_shell_spyware_holy_potatoes_were_in_space/

Removing Achtung from mods folder = no connections whatsoever from Rimworld process
...thats all
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 19, 2019, 07:24:46 PM
Red Shell, as you linked, seems to part of the Steam API, not the mod. The mod invokes some parts of the Steam API for promotion purposes, as can be seen here in the source (https://github.com/pardeike/Achtung2/blob/fd93056035001a616a0cb600b4eb6b287a7020f6/Source/CrossPromotion.cs). In it is very likely that those methods must trigger that aspect of it, which is more difficult to say definitively. The Steam API for C# is merely a wrapper around unmanaged code, so quickly decompiling and viewing the code is not really an option. I can say definitively that there is nothing in the decompiled source code of the mod itself that references or uses anything affiliated with Red Shell.

I am not very familiar with Red Shell, but some quick DuckDuckGo searches seem to indicate that it is part of Steam, and can be found within it. Yet another reason why I choose not use Steam.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 19, 2019, 09:43:51 PM
The reason my mods use (or try to use) the steam api is that I patch in some cross promotion on the mod info page in RimWorld. It basically lists all my other mods by querying the steam api.

It was my assumption that the steam RimWorld version connects to it anyway and that the offline version would simply return empty results/errors when trying to use it.

The strange thing is that this is only used/activated when you go to the mod list and select one of my mods. Unless just liking to the steam dll itself does trigger the connections. Also: where did you get the Achtung binary from? I hope not from some of these shady mod websites but instead from my GitHub.

Suggestion: download the source of Achtung and just remove the file CrossPromotion.cs, then compile and use it. Probably want to remove the reference to Assembly-CSharp-firstpass.dll to be sure. Row 51-54 and 65 in https://github.com/pardeike/Achtung2/blob/master/Source/Achtung.csproj

If you want I can help you with that but it would need to wait until the weekend.

/Andreas
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 19, 2019, 11:03:46 PM
Alright, it took a few more changes (MultiModFix patches RW so it can handle mods that support multiple versions - now obsolete) but I compiled it and added it to the files of the newest release:

https://github.com/pardeike/Achtung2/releases/tag/v2.3.3

Download the AchtungOffline.zip from there and see if it behaves differently.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 20, 2019, 12:39:05 AM
(https://i.ibb.co/jZLJdyL/yolo2.jpg) (https://ibb.co/pr3hgf3)

Same as before w the *offline* version

That being said there still seems to be some misunderstanding regarding Steam on my end - i dont use steam, dont use steam Rimworld and dont even have Steam installed on this Win10 install. IF i have to do something through Steam i use a laptop and thats quite rare in conjunction w Rimworld considering most Mods can be aquired from here or the Workshop includes a github link as well unless the author is really stubborn...

The first 2.3.3 version was indeed downloaded from your github/releases like 2 weeks ago going by timestamp.

It seems like the cloud its connecting to opens the treasuredata connections as well and keeps them open?
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 20, 2019, 12:40:51 AM
Can confirm that removing the usage of the steam api removes the extra communication (done in DMR free Rimworld but with steam installed in general):

With offline Achtung https://ibb.co/VYwWcqB (https://ibb.co/VYwWcqB)
(https://i.ibb.co/B2nV5Cs/with-offline-achtung.png)

WIth normal Achtung https://ibb.co/h9q4664 (https://ibb.co/h9q4664)
(https://i.ibb.co/XLwKQQK/with-achtung.png)

With no mods https://ibb.co/qYmTQMb (https://ibb.co/qYmTQMb)
(https://i.ibb.co/XxFcRZm/without-achtung.png)

Edit: added original image links
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Canute on November 20, 2019, 02:22:57 AM
I think these "in.treasuredata.com" are based on your mashine not the mod.
At my mashine with DRM-free version i don't get connection to it.
Since you don't use steam like me, it can't be the fault from steam.
QuoteTreasure Data
Arm Treasure Data Customer Data Platforms (CDPs) integrate and use marketing data from many different platforms, including email, lead generation, CRM, loyalty data, social media data, POS and other purchase data, second- and third-party data, and more
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 20, 2019, 10:00:17 AM
Quote from: atewithouttabIe on November 20, 2019, 12:39:05 AM
That being said there still seems to be some misunderstanding regarding Steam on my end - i dont use steam, dont use steam Rimworld and dont even have Steam installed on this Win10 install.

You don't need to have Steam installed if a game includes Steam libraries. An actual Steam installation is not required for games to run, even in many cases for the Steam versions of the game. If you take a look at the pirate scene, about 99% of all games prove this point. They typically alter the Steam files to bypass DRM and include simply include the relevant ones locally.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: atewithouttabIe on November 20, 2019, 10:28:56 AM
Alright...

famous last words on this
...out of 111 Mods total, 110 mods in folder ie all cept Achtung = no Rimworld treasuredata connection, add Achtung to the list of 110 Mods and that connection pops up

No steamxx.api in rimworld directory nor elsewhere considering i dont use it as i have stated multiple times at this point

#s

really done after this just couldnt resist:
Quote from: Canute on November 20, 2019, 02:22:57 AM
I think these "in.treasuredata.com" are based on your mashine not the mod.
At my mashine with DRM-free version i don't get connection to it.
Since you don't use steam like me, it can't be the fault from steam.

...fixed your connection screenshot for you - your fritz box is cckblocking the treasuredata connection, nothing more, its still there:
(https://i.ibb.co/GQ2K59t/Achtung.jpg) (https://ibb.co/MkVYCfG)

the port80 one is the cloud thing where Achtung calls "yo, sup" ie the counter brain has implemented, the other two..are..not

There you go - so same thing i get but i dont use a router atm


Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: ForeverZer0 on November 20, 2019, 12:04:57 PM
Quote from: atewithouttabIe on November 20, 2019, 10:28:56 AM
No steamxx.api in rimworld directory nor elsewhere considering i dont use it as i have stated multiple times at this point

"Non-steam" and "DRM-free" are not synonymous. Check these directories, all from the DRM-free version, not downloaded from Steam.

Windows:
<Rimworld Directory>\RimWorldXXXXWin_Data/Plugins/

Mac:
<Rimworld Directory>/Contents/Plugins/x86/
<Rimworld Directory>/Contents/Plugins/x86_64/
<Rimworld Directory>/Contents/Plugins/CSteamworks.bundle/Contents/MacOS/


Linux:
<Rimworld Directory>/RimWorldXXXXLinux_Data/Plugins/x86/
<Rimworld Directory>/RimWorldXXXXLinux_Data/Plugins/x86_64/


If you could confirm that your installation does not contain such directories and/or none of them contain the Steam libraries.
Title: Re: Achtung Mod oddity - doesnt fit in MODS section really
Post by: Brrainz on November 20, 2019, 01:18:34 PM
Your 110 mods don't use/reference the Assembly-Csharp-firstpass.dll that even DRM free RimWorld has. It's very uncommon and most mod authors don't even know that it exists.  That proofs nothing, you need to reason with me and look at the traces I did with all three scenarios (vanilla, normal and stripped Achtung).

On my end, I don't do anything related to the two extra calls.