Ludeon Forums

RimWorld => Releases => Mods => Outdated => Topic started by: DonationBox on February 15, 2017, 05:48:01 AM

Title: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DonationBox on February 15, 2017, 05:48:01 AM
I've Got You In My Sights (NOW WORKING)

Made By: DonationBox
Helped a loooooot: spdskatr and Brrainz


This is a simple assembly fix that solves the problem of attackers not being able to shoot at pawns that are inside embrasure bunkers or other impassible but shoot through-capable walls, or bases completely surrounded by fences. It will not work if there are no doors on the bunkers or bases because of a quirk in the game's programming that I'm going to fix later, so you can still cheese with completely inaccessible turrets if you want. Fixed now.

Update 0.0.2 - The mod now officially works after some dirty solutions that shouldn't matter in the current version of RimWorld. Invading hostiles can now freely target inaccessible pawns with ranged weapons, although your pawns, when put on autoattack mode and not drafted, cannot do the same until I figure out how to patch that, but it shouldn't affect gameplay unless you are fond of walling in pawns.

https://www.dropbox.com/s/gfqacd4mvsgc7zy/I%27ve%20Got%20You%20In%20My%20Sights.zip?dl=0 (https://www.dropbox.com/s/gfqacd4mvsgc7zy/I%27ve%20Got%20You%20In%20My%20Sights.zip?dl=0)
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.1)
Post by: Spdskatr on February 15, 2017, 06:12:46 AM
To be honest, without you doing it I would have had no idea how to make this mod. Isn't it just obvious when you see someone else do it?  :D
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.1)
Post by: Navy1227 on February 15, 2017, 01:31:52 PM
So basically if I use ED's embrasures, I was unable to be shot back at by attacking pawns? Now with this mod I will actually be susceptible to return fire? It's been a long night for me, I'm just trying to double check things is all.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.1)
Post by: crusader2010 on February 15, 2017, 02:06:38 PM
Also, is it the same with the embrasures from Combat Realism? Do they work correctly or do they need this patch (with/without a compatibility patch)? thanks :)
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.1)
Post by: DonationBox on February 15, 2017, 10:14:33 PM
It's for fixing a very specific interaction where raiders cannot target pawns that they cannot path to. If you use embrasures you may or may not run into this problem depending on how you set them up.

There should be no compatibility issues.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.1)
Post by: XeoNovaDan on February 19, 2017, 10:52:13 AM
This looks to potentially be a critical balance fix for ED-Embrasures, definitely liking the idea of this. If this project moves on, I'll definitely be inclined to download mods such as ED-Embrasures which'd otherwise just be significantly too overpowered.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DonationBox on February 22, 2017, 06:23:10 AM
Update 0.0.2 - The mod now officially works. See main post for link and details.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Sniper Pilot on February 22, 2017, 12:26:45 PM
Is it just me or can I not see the link?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: CathDubh on February 22, 2017, 01:23:52 PM
no link
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DonationBox on February 22, 2017, 07:44:47 PM
Link's back
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Gizamaluke on February 24, 2017, 08:31:47 AM
So, just to clarify, i have 3 questions about this fix.

1)If i build an embrasure and position my man next to it the enemy can shoot back from distance?
2)If i put my man in a room without doors with an embrasure wall the enemy can shoot at him and if i tell him to do so he will fire back at them?
3)If my man is in sealed building with a door but no embrasures and just walls the enemy cannot shoot him until they break down the door?
All yes to the above?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DonationBox on February 26, 2017, 05:32:14 PM
Quote from: Gizamaluke on February 24, 2017, 08:31:47 AM
So, just to clarify, i have 3 questions about this fix.

1)If i build an embrasure and position my man next to it the enemy can shoot back from distance?
2)If i put my man in a room without doors with an embrasure wall the enemy can shoot at him and if i tell him to do so he will fire back at them?
3)If my man is in sealed building with a door but no embrasures and just walls the enemy cannot shoot him until they break down the door?
All yes to the above?

Yes to all of the above.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Derp on February 27, 2017, 02:03:49 PM
Is there some special load order for the mod?  I just tried this out by slapping it at the bottom of my other mods, but ran into the same targeting issues with enclosed (ED-)embrasures.

Also does the mod really need a cutesy name?  "Embrasure Targeting Fix" would have been fine.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Nanao-kun on February 27, 2017, 03:23:04 PM
Seems to work for me.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on February 28, 2017, 07:40:25 PM
Save compatible?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Jaxxa on February 28, 2017, 08:56:46 PM
It looks like it is using a Harmony Patch and I think that it should be Save Compatible to Add/Remove.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Justas love on March 05, 2017, 11:23:28 AM
does this work with cr?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: faltonico on March 05, 2017, 02:26:13 PM
Will this work with Brunayla's (https://ludeon.com/forums/index.php?topic=7179.msg71239#msg71239) embrasures?
Though i've seen federation drones from Rimsenal shooting pawns the other side of those embrasures without this.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DonationBox on March 08, 2017, 03:49:28 AM
This will work with any embrasure. If you had drones shoot at you without this patch it means that they still have a path to reach you because the game used the same target finding algorithm for both ranged and melee. This patch specifically addresses that niche.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Tgr on March 18, 2017, 03:36:52 PM
needs to be updated to newest version of harmony
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on March 25, 2017, 06:24:03 PM
Anyone have advice on how to update this or when it will be?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Spdskatr on March 26, 2017, 05:29:35 AM
Ah rip. DonationBox hasn't been on for a while. Oh well. I'll see if I can wake him/her up.

^^
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Tgr on March 27, 2017, 01:19:32 PM
what's the risk of running this without the update? would it break other harmony mods, or is there just a chance this one wouldn't work?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on March 27, 2017, 02:34:41 PM
@TREH Not sure, I've still been using the un-updated version and nothing seems to be broken for me. I also use a lot of mods. Maybe 200+
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: ZLF on March 28, 2017, 04:10:08 AM
Quote from: Dr_Zhivago on March 25, 2017, 06:24:03 PM
Anyone have advice on how to update this or when it will be?

I've tried to rebuild the dll with Harmony 1.0.9.1, and it works fine for me. Maybe you can have a try.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on March 28, 2017, 06:56:35 AM
Quote from: ZLF on March 28, 2017, 04:10:08 AM
I've tried to rebuild the dll with Harmony 1.0.9.1, and it works fine for me. Maybe you can have a try.

Any advice on how to do that exactly? Talking to an extremely unexperienced modder/xml editor
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: ZLF on March 29, 2017, 08:35:27 AM
Quote from: Dr_Zhivago on March 28, 2017, 06:56:35 AM
Any advice on how to do that exactly? Talking to an extremely unexperienced modder/xml editor

I use the MSBuild tools, you can also use Visio Studio instead. The source code is in the zip. All you need is too change the version of 0Harmony.dll in the .csproj file.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Tgr on March 31, 2017, 06:36:20 PM
If you have a fixed version couldn't you just post it?  ;)
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: ZLF on April 01, 2017, 10:04:43 AM
Quote from: TREH on March 31, 2017, 06:36:20 PM
If you have a fixed version couldn't you just post it?  ;)
Here it is.
It seems no problem for me, but I haven't made further tests.

[attachment deleted by admin due to age]
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Tgr on April 01, 2017, 05:34:35 PM
Thanks so much.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: DamionFury on April 22, 2017, 01:17:19 PM
Quote from: ZLF on April 01, 2017, 10:04:43 AM
Here it is.
It seems no problem for me, but I haven't made further tests.

Thanks, ZLF, for posting this. I'm on a Mac and it's not very easy for me to build ms projects. This resolved Harmony conflicts and seems to work just fine for me.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: onidlorah on May 09, 2017, 08:00:54 AM
Hey there, i just saw the mod ed-embrasures and there it was said to use this mod combined with his to make it more real. i downloaded and installed both mods. And as soon as i started the game in mods menu was a message telling me it's out of date with the harmony feature.. i don't know anything about modding so my question is.... Can i use this feature now or do i have to wait till it's updated, to work without problems. Thanks in advance haroldino
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on May 09, 2017, 08:45:28 AM
Quote from: onidlorah on May 09, 2017, 08:00:54 AM
Hey there

Mod author has been MIA for a while now. Use this version that someone else made and posted earlier in the comments.

[attachment deleted by admin due to age]
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: onidlorah on May 09, 2017, 09:37:21 AM
thank you zhivago ill try it now :d
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: vampiresoap on May 14, 2017, 02:33:28 PM
Quote from: Dr_Zhivago on May 09, 2017, 08:45:28 AM
Quote from: onidlorah on May 09, 2017, 08:00:54 AM
Hey there

Mod author has been MIA for a while now. Use this version that someone else made and posted earlier in the comments.

OMG thanks so much! This works wonders.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Dr_Zhivago on May 29, 2017, 04:28:32 AM
Has anyone tried this in A17?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Jaxxa on May 29, 2017, 04:49:11 AM
From what I have seen this mod might not be needed anymore.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Comrade Smartass on June 07, 2017, 01:14:24 PM
I tried the A16 mod in A17.  Causes raiders to totally ignore colonists unless melee attacked first, in which case the raiders will only attack back with melee.  Also, the embrasures mod still doesn't fix the issue this mod was made to fix yet.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: kaptain_kavern on June 07, 2017, 09:45:42 PM
Hey Comrade looks like there is a A17 version just a few post above
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Igams on July 15, 2017, 01:05:24 AM
Quote from: Jaxxa on May 29, 2017, 04:49:11 AM
From what I have seen this mod might not be needed anymore.

That's interesting. I notice you still recommend this for your Embrasure mod though so I guess this hasn't been proven yet? I wonder what happened. Maybe A17 changed targeting mechanics?
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Penitent Engine on August 07, 2017, 03:03:41 AM
Any word on whether it's still necessary? Thanks.
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: Chaos17 on August 07, 2017, 03:28:45 AM
This is a really nice mod, I use it mainly for my farm, I hate that the babies animals I got to get killed by predators, lol
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: kaptain_kavern on August 07, 2017, 09:40:04 AM
Quote from: Penitent Engine on August 07, 2017, 03:03:41 AM
Any word on whether it's still necessary? Thanks.
I guess Jaxxa meant that enemies behave normally and shoot back at you through embrasures without this mod.

That's what I get from the sentence, but I can't confirm nor infirm if it is working normally (haven't tested embrasures in A17 at all)
Title: Re: [A16][Fences and Embrasures Bug Fix] I've Got You In My Sights (0.0.2)
Post by: GlitchKs on August 07, 2017, 11:05:11 AM
I will rephrase what others said here in clear terms.

This mod is no longer needed in A17. The AI now functions like this natively. This was very much needed in A16 but that is no longer the case.