Ludeon Forums

RimWorld => Bugs => Topic started by: Ragnar-F on April 20, 2020, 04:42:40 AM

Title: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: Ragnar-F on April 20, 2020, 04:42:40 AM
Only occurs in non-English clients (tested with German and French). This issue refers to names generated via RulePackDef (for example <li>WordImperial(p=4)->[SylB][SylB]</li> in Core\DefInjected\RulePackDef\RulePacks_Namers_People.xml).

For example, instead of 'Galo Elanekan', the name 'Galo elanekan' is generated for a pawn (the debug inspector shows <last>elanekan</last>).
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: Ragnar-F on April 28, 2020, 04:46:54 AM
Steps to reproduce #1:

Steps to reproduce #2:
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: b606 on May 02, 2020, 01:44:05 PM
The actual RimWorld code let the rulepack resolver do the job but it is not sufficient because the step after the rulepack, the semantic is lost and the stock c# ToTitleCase does not make it.

Name generator capitalizes nick names but not surnames, I suppose on purpose.

Something like <li>WordImperial(p=4)->[SylB_Cap][SylB][SylB]</li> with provided capitalized syllables in the RulePacks*.xml did not work, at least last time I checked (The strings might be lowercased somewhere).

There are at least 8 semantics (people/proper names, action and business names, art titles, generic quest titles etc. which drill down to three categories of the grammatical rules for french). The language worker can detect these with a complex callstack analysis (as I did), or else extra annotations in the translations files (postprocessed in the languageworker such as the russians did), but a proper function(s) in the codebase would be easier.
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: Ragnar-F on May 03, 2020, 06:57:54 AM
Randomly generated words in multi-word faction and locality names are also affected.
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: ison on May 07, 2020, 04:02:10 AM
Thanks, we'll look into it.
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: Ragnar-F on May 12, 2020, 08:05:29 AM
I could fix it by providing capitalized syllables and/or words as suggested by b606. The exact changes I made can be seen here: https://github.com/Ludeon/RimWorld-de/commit/dc8fe880182a4fedddf42c6f3774edfa82ee46a0.
Title: Re: [1.1.2609 rev627] Randomly generated last names are not capitalized
Post by: Kenneth on May 13, 2020, 06:22:05 AM
So it seems like this should be fixed by the individual languages. Thanks for reporting.