Ludeon Forums

RimWorld => Bugs => Topic started by: nnubnubnub on December 14, 2021, 12:41:27 AM

Title: [1.3.3200 + Ideology] Incomplete deletion of active role in fluid ideology
Post by: nnubnubnub on December 14, 2021, 12:41:27 AM
In the savefile linked at the bottom, I have a fluid ideology and enough points to make a change; the ideology currently allows the research specialist role (I'll just call it the "researcher role"), and I have two colonists with that role.

Using the ideology lightbulb icon in the lower right, I edit the ideology to give it a new meme.  One of the changes I make is to delete the researcher role.  After that, weirdness ensues:

The two colonists that were researchers, Crab and Pansy, are now marked as having no role assigned.  Indeed, they did lose the +70% research bonus that the researcher role gives.  However, in several ways they seem to still have the properties of the researcher role:
I'm not exactly sure what should happen here; it's a bit of a design question.  Maybe it should forbid you from deleting a role while colonists are still assigned to the role; though since you can't remove roles from downed colonists, this would suck if you had a researcher who was incapacitated long-term.  But, if deleting an active role is permitted, (a) I suspect it should still cause the "-15 Lost xyz role" malus, and (b) it should most definitely get rid of the commands and the forbidden work types; generally it should do everything that removing the role normally does.

Savefile from before changing the ideology: https://www10.zippyshare.com/v/YsLmoGoA/file.html
Title: Re: [1.3.3200 + Ideology] Incomplete deletion of active role in fluid ideology
Post by: Pheanox on December 17, 2021, 09:18:28 PM
Thanks for the bug report. The provided save was very helpful as well.  I'll get a report into the devs to investigate, looks like we need better cleanup after removal of roles and memes.
Title: Reform Ideology Role Change Bug
Post by: Andyfries on December 22, 2021, 01:45:11 AM
Minor issue, when I reformed my ideology I removed the Human Primacy meme, and so lost access to the production specialist role. However, the colonist who had the production specialist role somehow retained their production command ability despite not having the role anymore.
Title: Re: Reform Ideology Role Change Bug
Post by: nnubnubnub on December 22, 2021, 06:21:40 AM
This sounds like the same thing I encountered here: https://ludeon.com/forums/index.php?topic=55960.0

Do you also find that the former production specialist is still unable to do dumb labor, animals, cooking, plants, and mining?
Title: Re: Reform Ideology Role Change Bug
Post by: Pheanox on December 22, 2021, 11:17:44 AM
I will add this forum post to the bug report I've already made.  Thanks for the bug report.
Title: [1.3.3200] Ideology Role change bug collection
Post by: glass zebra on January 05, 2022, 02:05:29 PM
Changing the Role of someone in Ideology has several bugs and inconsistencies.

1. Swapping the role from plant specialist to research specialist does not work. The ritual finishes and you get the message that it was successful, yet the pawn is still a plant specialist. Case: https://steamuserimages-a.akamaihd.net/ugc/1841408985877626682/C2C7E332B3DC8F508AF82507E8DFF1C904CD5F6D/ -> https://steamuserimages-a.akamaihd.net/ugc/1841408985877626959/47F1A013DBC4963924B61AC3BF811C78E5405F93/
The other way around is not even selectable, since the research specialist disables the plant skill and therefor the requirements for the plant specialist (plant skill 6) do not seem to be fulfilled.
In addition to that, removing the plant specialist role after triggering the ritual to swap to the research one will make the pawn the research specialist instead of having no role.

2.Swapping and mood penalty:
2a. Removing the current role triggers the -15 mood debuff. Gaining a new role after that does not remove if.
https://steamuserimages-a.akamaihd.net/ugc/1841408985877627555/F8670F730A685B8D52899CDB73733EA8F85DDBC1/
https://steamuserimages-a.akamaihd.net/ugc/1841408985877627826/A308548D7A08EF28BF0E64BE96F64C599036D2A6/
Removing the new role will not trigger an additional debuff or overwrite it and the only way to remove the debuff then, is to become the role that triggered the debuff first.
2b.If you instead do not remove the role but just swap to a new one, the debuff is not triggered. This works for example going from plant specialist to moral guide. . Removing the new role then will put you back into your first roll instead not just remove all roles and trigger a mood penalty for the 2nd roll lose. https://steamuserimages-a.akamaihd.net/ugc/1841408985877696612/7C1C124CBABC35DE15EBD6D6BB9D920FB2B0C9A3/
This seems very inconsistent both for how the mood debuffs are handled and that the old role is apparently saved by swapping and fallen back to when the new one is removed.

3. Changing your leader will display stuff like the apparel requirement being overridden by the royal title, if your old leader had a royal title but the new ones does not: https://steamuserimages-a.akamaihd.net/ugc/1841408985877627224/53AE6BD6EE6FE1D9C8D90CA613741659D6A8B194/

Both DLCs, no mods used.