Is DefInjecting Japanese descriptions even a thing?

Started by GarbageDay, December 17, 2019, 08:25:38 PM

Previous topic - Next topic

GarbageDay

After trying to suss this out for hours i've come to ask if there's currently limits to what i can DefInject into Japanese.

I've got the name labels to inject fine but my descriptions defs all seem to default to "ア イ テ ム が ど の 位 良 く 作 ら れ た か を 示 し て い ま す ." meaning "Shows how well the item was made." in English.

A lot of base items in the game seem to default to the same "Shows how well the item was made." description as well (pilas, knifes, combat helmet, flakpants, etc) except for (what i've been able to find) the base tribal club which does have an actual non-default description.

I've downloaded one of the rimsenal weapon packs and a japanese translation patch to that and from what i've seen even though the translations patch has proper fleshed out descriptions in the .xml file they also default to "ア イ テ ム が ど の 位 良 く 作 ら れ た か を 示 し て い ま す ." in game.

PlEaSe HeLp

_______________________________________________________
1st Edit: I found some other guns within the rimsenal japanese patched mod that i used to trouble shoot that DID have injected descriptions in game so i looked into THOSE .XML files and it turned out the person who wrote that patch actually just messed up the def names on one branch of guns. So disregard the last part of my first post O.O

So let me just post my code for my gun:

<PSPJACKHAMMERBULLET.label>NC05 ジャックハンマ弾</PSPJACKHAMMERBULLET.label>
   
<PSPJACKHAMMER.label>NC05 ジャックハンマ</PSPJACKHAMMER.label>
<PSPJACKHAMMER.description>そのストッピングパワーと継続的発砲能力により、NC05 ジャックハンマは近接戦闘において恐ろしい武器となる。また、発射速度が2倍になるユニークなバーストモードを特徴としている。</PSPJACKHAMMER.description>

So there the label shows up correctly but thats it, PSPJACKHAMMER is 100% the defName for the gun so idk.
_______________________________________________________
2nd Edit: OKAY so i found a place in game where my custom descriptions did inject to -not in the regular gun's statmenu but instead in the tab where you'd check/drop your pawns gear when you hover over the weapon and get a splash. What is this, why is this, who is this, where is this, when is this? All the questions.
________________________________________________________
3rd Edit: So i'm skulling over the difference between the rimsnel patch that managed injection to where i want it to and all the other weapons that come up "アイテムがどの位良く作られたかを示しています ."  (Including base game weapons) i think maybe it's because "BaseHumanMakeableGun", "BaseMeleeWeapon_Sharp_Quality", and the other default ThingDefs don't want to play nice but that if i create a custom baseweapon def for my guns it might work.

Interesting I also found that base game grenades do indeed get Japanese descriptions along with those tribal clubs so i'm narrowing in on the idea that item quality has something to do with it since neither of those item have a craft quality like other weapons do.

________________________________________________________
4th Edit: Making my own ThingCategoryDef didn't do it.


GarbageDay

#1
Here's my current work version of my mod with all the japanese translations fleshed out but the descriptions still not injecting for some reason.
[github link to workversion of the mod removed after last post]

GarbageDay

#2
Issue resolved, and a summary of why i wasted the best years of my life on this:

First AHHHHHHHHHHHHHHHHHHH!!!!!!!!!!!!!!!!!!!!!!!

Now the example rimsnel GD weapons I looked in-game to teach myself didn't happen to have ANY item craft quality stat and the TE weapons (the other set i looked at) description-injection straight up failed which i confirmed when I looked at the XML files and saw the wrong defs being used (I used a 0.7v language patch since thats what popped up 1st on the workshop so this was probably fixed later since there is indeed a 1.0 patch further along)

I also don't actually read Japanese, also my brain is a big pencil eraser
That all combined to make me miss something really obvious:

品質 means ~quality
概要 means ~description
On the Japanese menu 品質 is listed before 概要
On the English menu description is listed right at the top before quality, it's what you see by default 

Have a good one folks.