A13 - Custom defs with duplicate class names crash mod loading

[Fluffy (l2032)]

Problem:
Two different mods create custom Def class (that is class in the C# sense), with the same name, but in different namespaces.
The game errors during mod load, mod config is reset.

Expectation:
Since the classes are namespaced, there should be no conflict an the game should run fine.

Replication:
Load the attached mod. It does absolutely nothing, but highlights the problem.

Solution:
In Verse.XmlLoader.AllDefsFromAsset, change

Code Select Expand

typeof(Def).AllSubclasses().ToDictionary((Type x) => x.Name);
to

Code Select Expand

typeof(Def).AllSubclasses().ToDictionary((Type x) => x.FullName);

( there may be more changes to be made, but this is the source of the issue ).



[attachment deleted by admin - too old]

[ison]

Fixed, thanks.