Ludeon Forums

Ludeon Forums

  • December 17, 2018, 07:01:32 AM
  • Welcome, Guest
Please login or register.

Login with username, password and session length
Advanced search  
Pages: 1 ... 27 28 [29] 30 31 ... 34

Author Topic: [1.0] Giddy-up! (animal riding) - Added new mod: Giddy-up! Mechanoids  (Read 71690 times)

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile

Giddy-up Caravan needs an update. I think it's not compatible with the newest harmony version. While a recompile fixes the error message it doesn't actually work again.

It works fine for me, using the Harmony version that comes with Hugslib, which isn't updated for a while (it was a few days ago, but it got reverted). Did you manually install the latest harmony version (which is not included in Hugslib yet) ? Not asking you to do that, just curious as it might explain why it's not working for you. Anyhow, could you share the error using the Hugslib sharing functionality (press ctrl+f12). By the way, are you also sure this isn't a mod conflict?

« Last Edit: August 02, 2018, 06:31:52 AM by Roolo »
Logged

Syrchalis

  • Colonist
  • ***
  • Posts: 426
  • Refugee
    • View Profile

It worked fine before with my mods, so I'm rather certain it's not a conflict. The other GiddyUp mods work fine.

I'm using the newest Harmony Version (not the 1.2 release, the one with this commit, which is even newer). It fixes a bug that causes this error:
Code: [Select]
System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock] cannot be converted to target type: System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock]Which is also the error message i get if I use Giddy-up Caravan. If I recompile it with the newest harmony version the error is gone, but the mod doesn't function, however I don't get any new error.

https://git.io/fNKg3

This is a log of me playing with the recompiled version (the error is gone, but mod doesn't work).

Pick up and Haul doesn't work properly if the newest Harmony version isn't loaded first, so I load the newest Harmony version right after Core.
« Last Edit: August 02, 2018, 06:38:47 AM by Syrchalis »
Logged
Ever wondered what's inside that box? An arm? A leg? A heart? Wonder no more! Prosthetic icons

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile

It worked fine before with my mods, so I'm rather certain it's not a conflict. The other GiddyUp mods work fine.

I'm using the newest Harmony Version (not the 1.2 release, the one with this commit, which is even newer). It fixes a bug that causes this error:
Code: [Select]
System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock] cannot be converted to target type: System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock]Which is also the error message i get if I use Giddy-up Caravan. If I recompile it with the newest harmony version the error is gone, but the mod doesn't function, however I don't get any new error.

https://git.io/fNKg3

This is a log of me playing with the recompiled version (the error is gone, but mod doesn't work).

Pick up and Haul doesn't work properly if the newest Harmony version isn't loaded first, so I load the newest Harmony version right after Core.

I don't think the bug is really fixed in that commit, Pardeike says it's completely untested:

Quote
IMPORTANT: A bug has been discovered that results in the following exception being thrown: System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock] cannot be converted to target type: System.Collections.Generic.List1[Harmony.ILCopying.ExceptionBlock]

To reproduce, use Harmony v1.1 and v1.2+ alternating in patching the same method (one that contains try/catch logic). That triggers the conversion and this release should fail. Commit c28362a tries to fix the problem but is completely untested. A new version will be released as soon as everything works as expected.

I recommend using an older version of harmony (the one included in Hugslib). That's the one I test against. Alternatively you can wait for the new release of Harmony in which it really is fixed.

You cannot expect me to update my mods so they work with some unreleased work-in-progress on GitHub.
« Last Edit: August 02, 2018, 07:22:05 AM by Roolo »
Logged

mrree123

  • Muffalo
  • *
  • Posts: 4
  • Refugee
    • View Profile

any chance that you make riding around a sort of recreation thing?

it  would work like "going for a walk" but instead the pawn is riding his/her assigned animal provided it has obedience training.
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile

any chance that you make riding around a sort of recreation thing?

it  would work like "going for a walk" but instead the pawn is riding his/her assigned animal provided it has obedience training.


Yeah I like this idea. I considered it before but never got to implement it. It won't be high priority but maybe I'll give it a go in the future.
Logged

Syrchalis

  • Colonist
  • ***
  • Posts: 426
  • Refugee
    • View Profile

You cannot expect me to update my mods so they work with some unreleased work-in-progress on GitHub.
It's fine, I recompiled your mods with the newest harmony version (I think it's not on github yet) and they are working fine now.
Logged
Ever wondered what's inside that box? An arm? A leg? A heart? Wonder no more! Prosthetic icons

daisy

  • Muffalo
  • *
  • Posts: 1
  • :)
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #426 on: August 07, 2018, 09:09:35 AM »

hey, im not very smart at this kind of stuff, but whenever i add giddy-up core to my modlist i get a really huge bug log. :'(
am i doing something wrong?
here's the logs:
https://git.io/fNDOL

thank you! this mod seems really cool
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #427 on: August 07, 2018, 09:14:15 AM »

hey, im not very smart at this kind of stuff, but whenever i add giddy-up core to my modlist i get a really huge bug log. :'(
am i doing something wrong?
here's the logs:
https://git.io/fNDOL

thank you! this mod seems really cool

Do you have Hugslib installed, and did you put Giddy-up below hugslib in your mod list?

Edit: nvm it seems you did. I'll take a look at it when I'm home (on phone now)
« Last Edit: August 07, 2018, 09:17:36 AM by Roolo »
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #428 on: August 07, 2018, 11:09:13 AM »

Tynan renamed the 1.0 branch to 0.19 :( I updated all mods so the versions match again

Update:

Giddy-up! Core -> 1.0.5
Giddy-up! Battle Mounts -> 1.0.4
Giddy-up! Ride and Roll -> 1.0.3
Giddy-up! Caravan -> 1.0.1

Changed version from 1.0 to 0.19.



hey, im not very smart at this kind of stuff, but whenever i add giddy-up core to my modlist i get a really huge bug log. :'(
am i doing something wrong?
here's the logs:
https://git.io/fNDOL

thank you! this mod seems really cool

It should just work. I just tested it with the latest build. Maybe something went wrong with downloading or installing? I suggest deleting the mod and redownloading an re-installing it.
Logged

butanefireflies

  • Muffalo
  • *
  • Posts: 4
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #429 on: August 10, 2018, 09:29:45 PM »

Love the mod :) I found a quirky but harmless bug, thought I'd let you know - my pawn rode to the edge of the map such that her muffalo is standing on the absolute outer tile and she's apparently off the map - refer to the linked photo. Pushes a small red error, see the pastebin. Nothing big, but it's interesting!

https://imgur.com/a/ix9B2Pl

https://pastebin.com/5GALq6Py
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #430 on: August 12, 2018, 12:56:09 PM »

Love the mod :) I found a quirky but harmless bug, thought I'd let you know - my pawn rode to the edge of the map such that her muffalo is standing on the absolute outer tile and she's apparently off the map - refer to the linked photo. Pushes a small red error, see the pastebin. Nothing big, but it's interesting!

https://imgur.com/a/ix9B2Pl

https://pastebin.com/5GALq6Py

Interesting bug. Can definitely be considered an "edge case", (o dear, bad joke). I'll make sure a fix is included in the next update. Thanks for reporting.
Logged

Kassidoo

  • Drifter
  • **
  • Posts: 57
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #431 on: August 24, 2018, 09:55:33 AM »

[B19] Hi, today after running fine for hours (Despite some others mods spamming errors constantly) it suddenly started to lag horribly and I found out why. It seems when the game tried to spawn a caravan something broke and it kept spawning more and more and more people to the caravan, this is the error log. I honestly have no idea what mod caused it but I saw in mentioned Giddyup so I'll try here first: https://www.dropbox.com/s/mx43ghyt6hq8hb2/output_log.txt?dl=0

Image of the "caravan"


Code: [Select]
System.NullReferenceException: Object reference not set to an instance of an object
at Verse.GenList.NullOrEmpty<Verse.Pawn> (System.Collections.Generic.IList`1<Verse.Pawn>) <0x0003d>
at GiddyUpCaravan.Utilities.VisitorMountUtility.mountAnimals (System.Collections.Generic.List`1<Verse.Pawn>&,RimWorld.IncidentParms) <0x00029>
at (wrapper dynamic-method) RimWorld.IncidentWorker_TraderCaravanArrival.TryExecuteWorker_Patch0 (object,RimWorld.IncidentParms) <0x0010f>
at RimWorld.IncidentWorker.TryExecute (RimWorld.IncidentParms) <0x00024>
at RimWorld.Storyteller.TryFire (RimWorld.FiringIncident) <0x0008e>
at RimWorld.IncidentQueue.IncidentQueueTick () <0x000c4>
at RimWorld.Storyteller.StorytellerTick () <0x0002f>
at Verse.TickManager.DoSingleTick () <0x00610>
« Last Edit: August 24, 2018, 09:57:45 AM by Kassidoo »
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #432 on: August 24, 2018, 10:07:41 AM »

[B19] Hi, today after running fine for hours (Despite some others mods spamming errors constantly) it suddenly started to lag horribly and I found out why. It seems when the game tried to spawn a caravan something broke and it kept spawning more and more and more people to the caravan, this is the error log. I honestly have no idea what mod caused it but I saw in mentioned Giddyup so I'll try here first: https://www.dropbox.com/s/mx43ghyt6hq8hb2/output_log.txt?dl=0

Image of the "caravan"


Code: [Select]
System.NullReferenceException: Object reference not set to an instance of an object
at Verse.GenList.NullOrEmpty<Verse.Pawn> (System.Collections.Generic.IList`1<Verse.Pawn>) <0x0003d>
at GiddyUpCaravan.Utilities.VisitorMountUtility.mountAnimals (System.Collections.Generic.List`1<Verse.Pawn>&,RimWorld.IncidentParms) <0x00029>
at (wrapper dynamic-method) RimWorld.IncidentWorker_TraderCaravanArrival.TryExecuteWorker_Patch0 (object,RimWorld.IncidentParms) <0x0010f>
at RimWorld.IncidentWorker.TryExecute (RimWorld.IncidentParms) <0x00024>
at RimWorld.Storyteller.TryFire (RimWorld.FiringIncident) <0x0008e>
at RimWorld.IncidentQueue.IncidentQueueTick () <0x000c4>
at RimWorld.Storyteller.StorytellerTick () <0x0002f>
at Verse.TickManager.DoSingleTick () <0x00610>

Thanks for reporting. The error you showed cannot possibly be the cause of the lag. It still needs fixing so I'll look into it. As for the lag, mods spamming the log frequently are much more likely the cause. If you share the entire hugslib log using ctrl+f12 I might be able to help (please don't use another method for sharing it).
Logged

Kassidoo

  • Drifter
  • **
  • Posts: 57
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #433 on: August 24, 2018, 10:18:47 AM »

I think the lag is because of the sheer amount of people (100+ spawning + animals + gear), I'm running the game atm, ill upload the log as soon as the caravan comes again.

Edit: It seems every time the error comes an entire new caravan spawns, as I have only 33 errors but several 100s of people.
Here's the output log, I have no idea what the DamageMotes error is either but it doesn't cause any performance or play issues; https://git.io/fAtQy

Minimum 80 muffalos, couldnt select more haha https://cdn.discordapp.com/attachments/140890123741954049/482555777580793857/unknown.png
« Last Edit: August 24, 2018, 10:24:43 AM by Kassidoo »
Logged

Roolo

  • Colonist
  • ***
  • Posts: 524
  • Refugee
    • View Profile
Re: [1.0] Giddy-up! (animal riding) - June 23th - Everything updated to 1.0
« Reply #434 on: August 24, 2018, 10:35:40 AM »

I think the lag is because of the sheer amount of people (100+ spawning + animals + gear), I'm running the game atm, ill upload the log as soon as the caravan comes again.

Edit: It seems every time the error comes an entire new caravan spawns, as I have only 33 errors but several 100s of people.
Here's the output log, I have no idea what the DamageMotes error is either but it doesn't cause any performance or play issues; https://git.io/fAtQy

Minimum 80 muffalos, couldnt select more haha https://cdn.discordapp.com/attachments/140890123741954049/482555777580793857/unknown.png
Ok it's much more clear now. Well indeed, if caravans keep spawning like that, Giddy-up Caravan is indeed the issue. I think the latest build of Rimworld might have broken it, or it might be a mod conflict. Either way, I'll look into it, but I'm away for the entire weekend, so you have the wait a few days. You can safely disable Giddy-up Caravan in your existing game in the meantime. Don't disable Giddy-up Core though. You can use the dev tools to remove the spawned pawns.
« Last Edit: August 24, 2018, 10:38:08 AM by Roolo »
Logged
Pages: 1 ... 27 28 [29] 30 31 ... 34