[1.0.1964] Changes to storage containers results in weird behavior - Minor

Started by historic_os, July 13, 2018, 07:48:49 PM

Previous topic - Next topic

historic_os

It seems like there is a confusion in stockpiles now between "in" and "on" as both type of items now considered as contained in a stockpile.

I came across this bug when a user reported unexpected behavior in the RW 1.0 version of my mod.
It's a minor bug and i doubt it actually matters to the vanilla game, but figured its best I report it just in case.

For example, if you build a lamp inside a stockpile(installed, not minified).
The lamp thing category will be "Building" as opposed to "Item" when minified.
This is the expected behavior, obviously. However, the stockpile instance will now:
1. Include it in its AllContainedThings
2. This one i might be wrong about (can't remember for sure) but:
On default storage settings, its StorageSettings.AllowedToAccept(Thing) method will return true when given the Building type thing.

To reproduce, you will need to be able to debug and print stockpile's contained things.
Just place a lamp in a stockpile and it will be contained in the Zone_Stockpile.AllContainedThings variable.
Here's a picture of the stockpile returning a Building type as contained item(installed lamp):



I'm assuming this is a bug and not intended change. If it was intended, feel free to ignore this report.