Ludeon Forums

Ludeon Forums

  • July 12, 2020, 06:34:01 AM
  • Welcome, Guest
Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: [1.1.2633 rev1099] String not directly translatable  (Read 142 times)

Ragnar-F

  • Drifter
  • **
  • Posts: 36
  • Refugee
    • View Profile
[1.1.2633 rev1099] String not directly translatable
« on: May 14, 2020, 07:58:43 AM »

It would be nice if "Terrain building in progress." is directly translatable. Currently, it is only indirectly translatable via ImpliedDefs.xml, unnecessarily wasting system resources as it needs to be translated for each floor type. Edit: Does not need to be translated. The string will be displayed in ImpliedDefs.xml, but in the end the game will display the normal description of each floor when under construction.

You can find this string in ThingDefGenerator_Buildings.cs. I would suggest either handling it the same way as with meat descriptions which can be found in Data\Core\Languages\English\Keyed\Misc.xml under MeatDesc, or just remove the string since it doesn't really provide any value.
« Last Edit: May 14, 2020, 09:37:42 AM by Ragnar-F »
Logged

Ragnar-F

  • Drifter
  • **
  • Posts: 36
  • Refugee
    • View Profile
Re: [1.1.2633 rev1099] String not directly translatable
« Reply #1 on: May 14, 2020, 03:50:22 PM »

Another one in KeyBindingDefGenerator.cs:

Code: [Select]
keyBindingDef.label = "Toggle " + mainButtonDef.label + " tab";
This string can be seen multiple times in the keyboard settings.

There are two other strings in this file that might deserve a translation, but I have no idea where they appear in the game.

Code: [Select]
keyBindingCategoryDef.label = designationCategoryDef.label + " tab";
keyBindingCategoryDef.description = "Key bindings for the \"" + designationCategoryDef.LabelCap + "\" section of the Architect menu";
Logged

ison

  • Developer
  • Planetologist
  • *****
  • Posts: 2356
    • View Profile
Re: [1.1.2633 rev1099] String not directly translatable
« Reply #2 on: May 26, 2020, 07:06:21 AM »

Aren't these fields translatable by def injections just like other defs?
Logged

Ragnar-F

  • Drifter
  • **
  • Posts: 36
  • Refugee
    • View Profile
Re: [1.1.2633 rev1099] String not directly translatable
« Reply #3 on: May 26, 2020, 10:08:26 AM »

No, they are not directly translatable, only indirectly via ImpliedDefs.xml as seen here. The disadvantage of ImpliedDefs.xml is that you have to add new items manually as seen here - the cleanup tool does not do this. This unnecessarily requires extra attention from the translator.

It would be best to provide something like "<ToggleTab>Toggle {0} tab</ToggleTab>", if possible. So part of the code should look like this:

Code: [Select]
keyBindingDef.label = "ToggleTab".Translate(mainButtonDef.label);
As for the other strings, I'm not sure if they need to be made translatable at all. I can't figure out where exactly they appear in the game.
Logged