[1.2] Scribe_Values.Look default value is ignored

Started by Hexicube, April 10, 2021, 01:07:09 PM

Previous topic - Next topic

Hexicube

When working on settings for my mod I noticed that my defaults were being ignored, after poking with dotPeek I see that this issue is in vanilla code.

Verse.ScribeExtractor.ValueFromNode<T> has the variable defaultValue passed in, however this is only used if there's an error in parsing or subNode is missing. For some reason, all other default returns use "default (T)". I'm assuming these should also be returning defaultValue.

If it helps, this was noticed on int config values.