[B18] VeinMiner [] Mine all the veins! []kaptain_kavern & Gentz & JuliaEllie

Started by JuliaEllie, January 25, 2015, 07:03:30 AM

Previous topic - Next topic

nuschler22

Quote from: rshingleton on December 19, 2016, 11:49:17 PM
I used this mod as a base and updated for A16 under the name MineItAll, full credit given for original mod.

Steam:
https://steamcommunity.com/sharedfiles/filedetails/?id=821866381

Non-Steam
https://www.dropbox.com/s/gde9ymeblw9w64i/MineItAll.zip?dl=0

Just a warning, MineItAll will show it's compatible with the A16 update, but causes a crash and prevents restarting the game.

Rock5

It was already updated to A16 by Hatti.
https://ludeon.com/forums/index.php?topic=9616.msg283437#msg283437.

And it was based on my fixed version with a few extra features. Which version was yours based on?

Here is my original post if you want to know what I changed.
https://ludeon.com/forums/index.php?topic=9616.msg275999#msg275999
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport

nuschler22

Quote from: Rock5 on December 20, 2016, 07:38:42 PM
It was already updated to A16 by Hatti.
https://ludeon.com/forums/index.php?topic=9616.msg283437#msg283437.

And it was based on my fixed version with a few extra features. Which version was yours based on?

Here is my original post if you want to know what I changed.
https://ludeon.com/forums/index.php?topic=9616.msg275999#msg275999

I used the Steam version that shows it's compatible with A16.

I downloaded and redownloaded it about an hour ago and it causes a crash each time, with not being able to restart.

Edit:  I downloaded the one from your link, and it shows as red in the Steam mods.  Don't know if you're on Steam, but that means it's not compatible (or the game doesn't think it's compatible).

The steam version I'm talking about is called MineItAll which is a clone of this.  That shows as white, or compatible, but crashes the game.   The steam author is aware of the conflict according to the Workshop page.

Rock5

I originally updated Veinminer to A15 with extra features. That's the second link and I never updated it to A16.

The top link was updated to A16 based on my version. I've tested it. It works perfectly. Did you download the second link by mistake?
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport

nuschler22

Quote from: Rock5 on December 20, 2016, 08:25:05 PM
I originally updated Veinminer to A15 with extra features. That's the second link and I never updated it to A16.

The top link was updated to A16 based on my version. I've tested it. It works perfectly. Did you download the second link by mistake?

Just to confirm, the first is the one from a link that just says Dropbox?

I'll give that a try.

I think I did use the second link. Are you on Steam or able to upload there so others can use it? I don't know how it works with sharing/cloning mods.

rshingleton

I'll start a new thread on this as well. There was a problem with the first release I did where a remant pdb file was causing crashes for some people.

Here's the lates dropbox link for the mod: https://www.dropbox.com/s/gde9ymeblw9w64i/MineItAll.zip?dl=0

----------------------
Right.....

Rock5

Quote from: rshingleton on December 20, 2016, 11:33:54 PM
I'll start a new thread on this as well. There was a problem with the first release I did where a remant pdb file was causing crashes for some people.

Here's the lates dropbox link for the mod: https://www.dropbox.com/s/gde9ymeblw9w64i/MineItAll.zip?dl=0

I checked this one out because you didn't say. Yes, it looks like it is based on my version.

The differences I can see are;
- New designator textures - I could take it or leave it.
- Dark brush texture - I don't like this as it's too hard to see. The bright red original is much better.
- Tidied up code - I like tidy code but I don't think that alone justifies a new name.
- Reverted one of my additions - I originally changed it so that you can mark a vein whether the visible ore is already marked or not. You've reverted it to be like the original where you need to clear the mark first before you can use the vein marker on it. I find that really annoying so I still prefer my version.

All in all I don't see enough justification for a new named mod. It is same mod but with a few cosmetic changes and a new name. And some of those changes made it worse. I'm just going to keep using Hattis A16 conversion of my version
https://ludeon.com/forums/index.php?topic=9616.msg283437#msg283437


As to steam, I don't like it. Personally I would want to share my mod where everyone can download it but I think steam only allows you to download it via steam (I could be wrong. It's very confusing to navigate). Here, everyone can download it. Steam and non steam users alike.
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport

rshingleton

Quote from: Rock5 on December 21, 2016, 04:53:01 PM
I checked this one out because you didn't say. Yes, it looks like it is based on my version.

The differences I can see are;
- New designator textures - I could take it or leave it.
- Dark brush texture - I don't like this as it's too hard to see. The bright red original is much better.
- Tidied up code - I like tidy code but I don't think that alone justifies a new name.
- Reverted one of my additions - I originally changed it so that you can mark a vein whether the visible ore is already marked or not. You've reverted it to be like the original where you need to clear the mark first before you can use the vein marker on it. I find that really annoying so I still prefer my version.

All in all I don't see enough justification for a new named mod. It is same mod but with a few cosmetic changes and a new name. And some of those changes made it worse. I'm just going to keep using Hattis A16 conversion of my version
https://ludeon.com/forums/index.php?topic=9616.msg283437#msg283437


As to steam, I don't like it. Personally I would want to share my mod where everyone can download it but I think steam only allows you to download it via steam (I could be wrong. It's very confusing to navigate). Here, everyone can download it. Steam and non steam users alike.

I see where you're coming from. I think it's more than just a vein miner with the other tools, but regardless, I made some additional tweaks this evening.

- Added your last point. This was not actually a reversion, I had some original source code without your addition and missed it since it was a Boolean value change at then end of the AcceptanceReport method, it took me a while to notice it.
- Bootstrapping: No more def file. I felt like this could possibly conflict with other mods. I pulled some code from CCL and a few other forum posts for detours and designator injection and added these in.
- Texture changes: these are last on my list. I didn't like the red, personal oppinion, but I don't necessarily like the dark either. I may tool with these more soon, working on another mod for prison extensions as well.
- Steam: Like it or don't, all personal opinion. I treat it like a build automation system. I can subscribe to mods, when they get updated, it installs the new version automatically. I see benefits in both sides, steam and non-steam, that's why I posted both links.

If you don't mind checking it out again, the old link should work, but here it is again: https://www.dropbox.com/s/gde9ymeblw9w64i/MineItAll.zip?dl=0

You're welcome to contribute as well, I consider it completely open.
----------------------
Right.....

Rock5

That's more like it! :)

The bootstrapping is awesome. Kudos to you. I would have done the bootstrapping myself, when I did my update, but I couldn't wrap my head around how to do it. Maybe looking at how you did it with a mod I'm familiar with with help me use it in the future.

So I'd use your version now, although I might change the brush texture until you come up with a better color.

Playing with it I noticed an exploit that I never noticed before, maybe because the bright red of the brush made it harder to see. The exploit is you can use the brush to look into mountains. I don't know if you can do anything about it but it would be great if you could.

You can also "look" into mountains with the vein mine designator. If you click the middle of a mountain you usually get a sound plus a message saying to have to click mineable ore. But if you hit a hidden clear area it makes a different sound with no message. This should be easy to fix. Just make it behave the same in both cases.

Here is a short video showing both cases.
https://vid.me/aNiN
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport

rshingleton

Quote from: Rock5 on December 22, 2016, 09:06:02 AM
That's more like it! :)

The bootstrapping is awesome. Kudos to you. I would have done the bootstrapping myself, when I did my update, but I couldn't wrap my head around how to do it. Maybe looking at how you did it with a mod I'm familiar with with help me use it in the future.

So I'd use your version now, although I might change the brush texture until you come up with a better color.

Playing with it I noticed an exploit that I never noticed before, maybe because the bright red of the brush made it harder to see. The exploit is you can use the brush to look into mountains. I don't know if you can do anything about it but it would be great if you could.

You can also "look" into mountains with the vein mine designator. If you click the middle of a mountain you usually get a sound plus a message saying to have to click mineable ore. But if you hit a hidden clear area it makes a different sound with no message. This should be easy to fix. Just make it behave the same in both cases.

Here is a short video showing both cases.
https://vid.me/aNiN

Interesting, I didn't notice the x-ray vision ability either. It might have something to do with the altitude setting? I don't know enough about the API yet, I'll tool with it tonight.

Let me know if you need help with the bootstrapping. I took it from some other mod(s) code base(s) that I found and modified it a bit.
----------------------
Right.....

Rock5

Quote from: rshingleton on December 22, 2016, 02:16:31 PM

Let me know if you need help with the bootstrapping. I took it from some other mod(s) code base(s) that I found and modified it a bit.

From what I can see there is the injectors class was added and the bootstrapper was added to the main MineItAll class.
Could you possible give a brief description of what each part does? I'm not too experienced with c# yet.
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport


Der Failer

Quote from: filippe999 on January 23, 2017, 08:56:48 AM
Is it still compatible with alpha 16?
No really if i recall correctly, but rshingleton has updated it in a new threat and i think there a also updates by Rock5 and Hatti somewhere in this threat.

Rock5

Yeah, rshingleton did a great job updating it. I use his version now. It's way better than mine and still has the features I added.
Rock5 [B18] Mods
- Butchers Can Count Meat
- Sun Lamp Planner
- JTZoneButtons
- RimSearch
- JTExport

Kardo