2019-08-22 12:31 EDT

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003630RimWorldGeneralpublic2019-04-01 11:47
Reporterison 
Assigned ToTynan 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusassignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0003630: Translation issues
Description1. GenText.CapitalizeSentences() capitalizes the first letter after ':' which is incorrect in some languages.
Solution: add capitalizeAfterColon flag to LanguageInfo

2. ToCommaList() adds a comma before "and" which is incorrect in some languages.
Solution: add useOxfordComma flag to LanguageInfo

3. Sometimes hard-coded text concatenation is incorrect in some languages and looks weird, e.g.:
- HealthCardUtility.DrawOverviewTab(). The line is: "text = text + pawn.def.label + ", " + "AgeIndicator".Translate(pawn.ageTracker.AgeNumberString);")
- Tradeable_Pawn.Label getter
- Pawn.GetTooltip()
- IncidentWorker_PsychicDrone.DoConditionAndLetter()
- Hediff_Injury.LabelInBrackets (getter)
- CompNeurotrainer.TransformLabel()
Reported here: https://ludeon.com/forums/index.php?topic=37826.0

4. "Psychic drone (male)" is impossible to translate correctly in some languages (e.g. Russian). Perhaps "male" should have its own special label in this case.
Reported here: https://ludeon.com/forums/index.php?topic=30182.15
And here: https://ludeon.com/forums/index.php?topic=43034.0

5. Perhaps the "Help translate RimWorld" links should be customizable.
Reported here: https://ludeon.com/forums/index.php?topic=42363.0

6. Caravan members tab needs to use Truncate().
Reported here: https://ludeon.com/forums/index.php?topic=42613.0

7. Pawn's age info in Health tab is not properly formatted in some languages.
Reported here: https://ludeon.com/forums/index.php?topic=37835.0

8. Required trainability is not translated. The error is here in Pawn_TrainingTracker:
return new AcceptanceReport("CannotTrainNotSmartEnough".Translate(td.requiredTrainability));
Reported here: https://ludeon.com/forums/index.php?topic=43391.0

9. Apparently these words can't be translated:
- 'cause' in floating-tip of health.
- 'Unsubscribe' button in mod menu.
- 'Poke', 'Stub', etc... in melee DPS description.
- Poke, Stab, etc... in description of melee armor penetration.
- Some units, like 'Warmup: - s'.

10. Missing "and" here:
"Diet: Vegetables, raw meat, ..., kibble" (Dialog_FormCaravan I think)

11. Translation cleaning tool: inconsistent newlines.
Reported here: https://ludeon.com/forums/index.php?topic=45818.0

12. ThoughtDefs should either have labelFemale or allow using {PAWN_gender}.
Reported here: https://ludeon.com/forums/index.php?topic=46112.0

13. There should be 2 NamerPersonTribal, one for male and one for female.
Reported here: https://ludeon.com/forums/index.php?topic=46651.0

14. More feedback and issues:
Here: https://ludeon.com/forums/index.php?topic=43979.0 (New keyed translations format thread)
And here: https://ludeon.com/forums/index.php?topic=44000.0 (Request: Help check the language workers for accuracy thread)

15. Gender-neutral Keyed entries in Pawn info readout could be made gender-dependent for better translation: Dead, Injured, Incapacitated, DownedLower, DeadTime, Mood_MentalState, Mood_AboutToBreak, Mood_Neutral, Mood_Content, Mood_Happy, HungerLevel_Starving, HungerLevel_UrgentlyHungry, HungerLevel_Hungry, HungerLevel_Fed, HungerLevel_Exhausted, HungerLevel_VeryTired, HungerLevel_Tired, HungerLevel_Rested, Kidnapped, Missing.
DefInjected entry: Wait_Downed.reportString

16. GenText.CapitalizeSentences method doesn't allow using abbreviations, e.g. it outputs «Макс. Дальность полёта» instead of the desired «Макс. дальность полёта» (incorrect capitalization)

17. Add {PAWN_articleIndef} and {PAWN_articleDef} symbols

18. GrammarResolver should support gender conditionals (just like GrammarResolverSimple)

19. Allow creating a WordInfo/Variants file with different forms of nouns. It would look like this:
A, B, C
a, b, c
...
and it could be used like this:
[WEAPON_label : 2] which would be resolved to B if WEAPON_label was A.
(or maybe [WEAPON_label[2]])

20. Blueprint labels are apparently incorrect:
"
For example, keyed entries in Misc.xml are:
  <ThingMadeOfStuffLabel>{1} из {0}</ThingMadeOfStuffLabel>
  <BlueprintLabelExtra> (проект)</BlueprintLabelExtra>
  <FrameLabelExtra> (в процессе сборки)</FrameLabelExtra>
Values in DefInjected\ThingDef\Various_Stone.xml are:
  <BlocksGranite.label>блоки гранита</BlocksGranite.label>
  <BlocksGranite.stuffProps.stuffAdjective>гранита</BlocksGranite.stuffProps.stuffAdjective>
So, format for a building should be "Стена из гранита" (granite blocks wall).
For a finished bilding everythig looks fine.
For blueprints the situation is different. The final label is "Стена (проект) из гранита". Expected value is "Стена из гранита (проект)".
For frames the situation is even more different: "Блоки гранита стена (в процессе сборки)". Expected value is "Стена из гранита (в процессе сборки)".
"

21. Greek language needs a language worker

22. GrammarResolver should always allow using X_definite and X_indefinite even if X is just an ordinary symbol. It should work like this: first see if X_definite exists, if not, then strip _definite or _indefinite and run Find.ActiveLanguageWorker.WithDefiniteArticle()

23. Check if the French language worker needs to be updated as per https://github.com/Ludeon/RimWorld-fr/issues/239

24. These keyed translations are missing: GoodwillChangedReason_RequestedTrader, GoodwillChangedReason_RequestedMilitaryAid

25. JobDriver uses a weird way to resolve text, it just looks for "TargetA", "TargetB", etc. strings. We should use GrammarResolverSimple here. This would allow using things like _definite. It should be back-compatible though, so we should still replace "TargetA" strings.

26. Some nouns are always plural in some languages, so we'd either need {0_gender ? A : B : C : D} or {0_count ? {0_gender ? A : B : C} : {0_gender ? A : B : C}}. https://ludeon.com/forums/index.php?topic=43979.msg455127#msg455127
TagsNo tags attached.
Fixed After
Attached Files

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2018-12-06 07:58 ison New Issue
2018-12-06 07:58 ison Status new => assigned
2018-12-06 07:58 ison Assigned To => Tynan
2018-12-06 08:08 ison Description Updated View Revisions
2018-12-06 08:16 ison Description Updated View Revisions
2018-12-06 08:29 ison Description Updated View Revisions
2018-12-06 08:36 ison Description Updated View Revisions
2018-12-06 08:39 ison Description Updated View Revisions
2018-12-06 08:42 ison Description Updated View Revisions
2018-12-06 08:48 ison Description Updated View Revisions
2018-12-06 08:54 ison Description Updated View Revisions
2018-12-06 08:58 ison Description Updated View Revisions
2018-12-06 09:00 ison Description Updated View Revisions
2018-12-06 09:08 ison Description Updated View Revisions
2018-12-07 07:14 ison Description Updated View Revisions
2018-12-17 19:52 ison Description Updated View Revisions
2018-12-23 14:03 ison Description Updated View Revisions
2018-12-23 14:13 ison Description Updated View Revisions
2018-12-23 14:14 ison Description Updated View Revisions
2019-01-26 08:11 ison Description Updated View Revisions
2019-02-19 05:26 ison Description Updated View Revisions
2019-02-28 03:43 ison Description Updated View Revisions
2019-02-28 04:02 ison Description Updated View Revisions
2019-02-28 04:13 ison Description Updated View Revisions
2019-04-01 11:47 ison Description Updated View Revisions
+Issue History