A13 - typos in the backstory XML files

Started by b0rsuk, June 02, 2016, 03:34:46 PM

Previous topic - Next topic

b0rsuk

I'm writing a tool for calculating colonist background statistics (resources.assets). In the process, I've found a bunch of typos, some of them of the copy&paste nature. Some of them, like typos in faction name(s), may cause the game to malfunction.

1. Traveller> in SpawnCategories - yes, including the "higher than" sign.
I'm aware there's British and American spelling, but xml definition files are probably not the place for that. Both spellings are used in the definition files. Backgrounds with the typo:

Pyromaniac
Mute
Refugee
Music lover
Child star
Child spy
Shopkeeper
Castaway
Gardener
Construction engineer
Blacksmith
Charity worker
Defector
Taxonomist
Geologist
Convent child
Test subject
Medical assistant
Cult child
Wreckage explorer
Apocalypse survivor
Story writer
Sailor
Actor
Biosphere manager
Counsellor
Recruiter
Drifter
Architect
Message carrier
Sculptor

The affected files: ExtraC.txt, ExtraD.txt

2. Trailing whitespace in BaseDesc:

Indworld Urchin
Genetic Scientist
Clone
Space Marine
Wasteland Ruffian
Construction Grunt
Engineered Pilot
Mercenary Chef

The affected file: rimworld_creations.txt

3. Trailing whitespace in names, nicknames etc:

                        <Nick>Kezel </Nick>
                        <First>Garrett </First>
                        <First>Steven </First>
                        <First>Johan </First>
                        <Last>Lancaster </Last>
                        <First>Glorijan </First>
                        <First>Callum </First>
                        <Last>Austerlitz </Last>
                        <First>Beato </First>
                        <First>Chris </First>
                        <First>Brendan </First>
                        <First>Jeronimo </First>
                        <First>Tobias </First>
                        <Nick>Aquarist </Nick>
                        <First>Vincent </First>
                        <Last>Nycz </Last>
                        <Nick>Agent </Nick>
                        <First>Raymond </First>
                        <Nick> </Nick>
                        <Last>Cole </Last>
                        <First>Gabriel </First>
                        <First>Josef </First>
                        <Nick> Eumel </Nick>
                        <First>Charlie </First>
                        <First>Sigurd </First>
                        <First>Ole </First>
                        <First>Marco </First>
                        <First>Fox </First>
                        <Last>Ferguson </Last>
                        <First>Ezequiel </First>
                        <First>Husamettin </First>
                        <First>Bryce </First>
                        <First>Alejandro </First>

Note Eumel has both leading AND trailing whitespace!

rimworld_creations.txt

More to come!

Tynan

Nice catch.

I think the code trims off space like this, but we should definitely clean the data too.
Tynan Sylvester - @TynanSylvester - Tynan's Blog

ison

Fixed "Traveller>" + all trailing whitespace in BaseDesc + all trailing whitespace in names (there were a few more). Thanks.