[1.0] Expanded Incidents (2018-10-30)

[deathstar]

Thank you for updating this mod! I last tried it out when homesickness was still very severe and unenjoyable, can't wait to take a look at the new version. It is still fully compatible with Psychology, right?

[System.Linq]

It's compatible with every mod.

[wwWraith]

I'm afraid it conflicts with Hospitality.

1. If Expanded Incidents installed without Psychology (as I did for testing), when guests come there are errors in console:

Code Select Expand

Exception ticking Carlotta: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at RimWorld.Pawn_InteractionsTracker.TryInteractWith (Verse.Pawn,RimWorld.InteractionDef) <0x00368>
at Hospitality.Harmony.Pawn_InteractionsTracker_Patch/TryInteractRandomly.Replacement (RimWorld.Pawn_InteractionsTracker,bool&) <0x002e2>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractRandomly_Patch1 (object) <0x00025>
at RimWorld.Pawn_InteractionsTracker.InteractionsTrackerTick () <0x0011b>
at Verse.Pawn.Tick () <0x002c8>
at Verse.TickList.Tick () <0x002c0>

Verse.Log:Error(String)
Verse.TickList:Tick()
Verse.TickManager:DoSingleTick()
Verse.TickManager:TickManagerUpdate()
Verse.Game:UpdatePlay()
Verse.Root_Play:Update()

2. After some time as the guests proceed to the colony (in the moment when most guests change their job from moving to something other) some of them (in all my tests it was 2 of them) halt their movement and start to just wandering with errors spamming:

Code Select Expand

Dax doing ThinkNode_DutyConstant with no duty.
Verse.Log:Error(String)
RimWorld.ThinkNode_DutyConstant:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
RimWorld.ThinkNode_Conditional:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Tagger:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Subtree:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
RimWorld.ThinkNode_Conditional:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.Pawn_JobTracker:DetermineNextConstantThinkTreeJob()
Verse.AI.Pawn_JobTracker:JobTrackerTick()
Verse.Pawn:Tick()
Verse.TickList:Tick()
Verse.TickManager:DoSingleTick()
Verse.TickManager:TickManagerUpdate()
Verse.Game:UpdatePlay()
Verse.Root_Play:Update()

3. If trying to open Guest tab after it happens, GUI may become weird (tabs and other windows including console drawed shaded or with some foreign elements), also generates error:

Code Select Expand

Exception filling tab Hospitality.ITab_Pawn_Guest: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
  at System.Collections.Generic.Dictionary`2[System.Int32,System.Single].get_Item (Int32 key) [0x00000] in <filename unknown>:0
  at Hospitality.LordToil_VisitPoint.GetVisitScore (Verse.Pawn pawn) [0x00000] in <filename unknown>:0
  at Hospitality.ITab_Pawn_Guest.FillTabGuest (Rect rect) [0x00000] in <filename unknown>:0
  at Hospitality.ITab_Pawn_Guest.FillTab () [0x00000] in <filename unknown>:0
  at Verse.InspectTabBase+<DoTabGUI>c__AnonStorey44F.<>m__65A () [0x00000] in <filename unknown>:0
Verse.Log:Error(String)
Verse.Log:ErrorOnce(String, Int32)
Verse.<DoTabGUI>c__AnonStorey44F:<>m__65A()
Verse.ImmediateWindow:DoWindowContents(Rect)
Verse.<WindowOnGUI>c__AnonStorey2C4:<>m__1B1(Int32)
UnityEngine.GUI:CallWindowDelegate(WindowFunction, Int32, GUISkin, Int32, Single, Single, GUIStyle)


4. If sending guests away (with a button on Guest tab), it starts spamming messages "Visitors from ... are leaving." and errors in the console:

Code Select Expand

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
  at System.Collections.Generic.Dictionary`2[System.Int32,System.Single].get_Item (Int32 key) [0x00000] in <filename unknown>:0
  at Hospitality.LordToil_VisitPoint.GetVisitScore (Verse.Pawn pawn) [0x00000] in <filename unknown>:0
  at Hospitality.LordToil_VisitPoint.Leave () [0x00000] in <filename unknown>:0
  at Hospitality.LordToil_VisitPoint.Cleanup () [0x00000] in <filename unknown>:0
  at Verse.AI.Group.Lord.GotoToil (Verse.AI.Group.LordToil newLordToil) [0x00000] in <filename unknown>:0
  at Verse.AI.Group.Transition.Execute (Verse.AI.Group.Lord lord) [0x00000] in <filename unknown>:0
  at Verse.AI.Group.Transition.CheckSignal (Verse.AI.Group.Lord lord, TriggerSignal signal) [0x00000] in <filename unknown>:0
  at Verse.AI.Group.Lord.CheckTransitionOnSignal (TriggerSignal signal) [0x00000] in <filename unknown>:0
  at Verse.AI.Group.Lord.LordTick () [0x00000] in <filename unknown>:0
  at Verse.AI.Group.LordManager.LordManagerTick () [0x00000] in <filename unknown>:0
  at Verse.Map.MapPostTick () [0x00000] in <filename unknown>:0
Verse.Log:Error(String)
Verse.Map:MapPostTick()
Verse.TickManager:DoSingleTick()
Verse.TickManager:TickManagerUpdate()
Verse.Game:UpdatePlay()
Verse.Root_Play:Update()


The issues #2 and #4 look like it was with mods adding animals to the guests, obviously it's not the cause here, but there may be some more related information: https://ludeon.com/forums/index.php?topic=11444.msg340682#msg340682 and later.

[System.Linq]

I can only confirm the first one as a problem with Expanded Incidents. The others I'll look into. I use Hospitality, so I'm pretty sure it's compatible.

[System.Linq]

Found the problem and fixed it.

[Almantuxas]

I've also had some problems while recruiting prisoners, but I think wwWraith found the bug. I'm going to test it after I get my hands on my own computer.

[Almantuxas]

I've also had some problems while recruiting prisoners, but I think wwWraith found the bug. I'm going to test it after I get my hands on my own computer.

Now it has also happened to me, while I was trying to tame a modden animal. I've tested it, and when the mod is active, this bug happens.

Code Select Expand

JobDriver threw exception in initAction. Pawn=Comrade, Job=Train A=Thing_Ori67865, Exception: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at RimWorld.JobDriver_InteractAnimal/<TalkToAnimal>c__AnonStorey25B.<>m__13 () <0x00096>
at Verse.AI.JobDriver.TryActuallyStartNextToil () <0x002d9>
lastJobGiver=RimWorld.JobGiver_Work, curJob.def=Train, curDriver=RimWorld.JobDriver_Train

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

JobDriver threw exception in initAction. Pawn=Comrade, Job=Train A=Thing_Ori67865, Exception: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at RimWorld.JobDriver_InteractAnimal/<TalkToAnimal>c__AnonStorey25B.<>m__13 () <0x00096>
at Verse.AI.JobDriver.TryActuallyStartNextToil () <0x002d9>
lastJobGiver=RimWorld.JobGiver_Work, curJob.def=Train, curDriver=RimWorld.JobDriver_Train

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

JobDriver threw exception in initAction. Pawn=Comrade, Job=Train A=Thing_Ori67865, Exception: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at RimWorld.JobDriver_InteractAnimal/<TalkToAnimal>c__AnonStorey25B.<>m__13 () <0x00096>
at Verse.AI.JobDriver.TryActuallyStartNextToil () <0x002d9>
lastJobGiver=RimWorld.JobGiver_Work, curJob.def=Train, curDriver=RimWorld.JobDriver_Train

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

JobDriver threw exception in initAction. Pawn=Comrade, Job=Train A=Thing_Ori67865, Exception: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at RimWorld.JobDriver_InteractAnimal/<TalkToAnimal>c__AnonStorey25B.<>m__13 () <0x00096>
at Verse.AI.JobDriver.TryActuallyStartNextToil () <0x002d9>
lastJobGiver=RimWorld.JobGiver_Work, curJob.def=Train, curDriver=RimWorld.JobDriver_Train

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

JobDriver threw exception in initAction. Pawn=Comrade, Job=Train A=Thing_Ori67865, Exception: System.TypeLoadException: Could not load type 'Psychology.PsychologyPawn' from assembly 'Psychology, Version=17.7.2.0, Culture=neutral, PublicKeyToken=null'.
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch1 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x00017>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at RimWorld.JobDriver_InteractAnimal/<TalkToAnimal>c__AnonStorey25B.<>m__13 () <0x00096>
at Verse.AI.JobDriver.TryActuallyStartNextToil () <0x002d9>
lastJobGiver=RimWorld.JobGiver_Work, curJob.def=Train, curDriver=RimWorld.JobDriver_Train

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)



EDIT: I think this is a completely different bug.

[System.Linq]

Alright, fixed.

[Mufflamingo]

So the clique event happened to me and it was weird I laughed so hard.

The groups came like this:

Group 1:
Leader:
Pawn A
Members:
Pawn B
Pawn C

Group 2:
Leader:
Pawn B
Members:
Pawn D

I laughed so hard when I saw that Group 2 Leader was a member of Group 1.

[System.Linq]

Pawn B probably likes Pawn A, but Pawn A doesn't like Pawn B.

e: Though that shouldn't be possible unless their opinion changes.

[System.Linq]

Updated to 2017-7-8:
-Major improvements to clique performance.
-Cliques should automatically dissolve if their leaders somehow become friends again.

[mrsebseb]

Alright, updated the mod (along side psychology) for a new game.
Soon as the colonists land this error pops up every 5-30 seconds:

Code Select Expand

Exception ticking Monograph: System.NullReferenceException: Object reference not set to an instance of an object
at ExpandedIncidents.Harmony.InteractionWorkerCliquePatch/<>c.<ManageCliques>b__0_0 (Verse.Pawn) <0x0000f>
at System.Linq.Enumerable/<CreateWhereIterator>c__Iterator1D`1<Verse.Pawn>.MoveNext () <0x00100>
at System.Linq.Enumerable.Count<Verse.Pawn> (System.Collections.Generic.IEnumerable`1<Verse.Pawn>) <0x000ac>
at ExpandedIncidents.Harmony.InteractionWorkerCliquePatch.AnyCliqueLinks (Verse.Pawn,Verse.Pawn,System.Collections.Generic.IEnumerable`1<Verse.Pawn>,bool&) <0x0003b>
at ExpandedIncidents.Harmony.InteractionWorkerCliquePatch.ManageCliques (RimWorld.InteractionWorker,Verse.Pawn,Verse.Pawn) <0x000a3>
at (wrapper dynamic-method) RimWorld.InteractionWorker.Interacted_Patch2 (object,Verse.Pawn,Verse.Pawn,System.Collections.Generic.List`1<Verse.RulePackDef>) <0x0002e>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractWith_Patch0 (object,Verse.Pawn,RimWorld.InteractionDef) <0x003d8>
at Hospitality.Harmony.Pawn_InteractionsTracker_Patch/TryInteractRandomly.Replacement (RimWorld.Pawn_InteractionsTracker,bool&) <0x002e2>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.TryInteractRandomly_Patch1 (object) <0x00025>
at (wrapper dynamic-method) RimWorld.Pawn_InteractionsTracker.InteractionsTrackerTick_Patch0 (object) <0x00124>
at Verse.Pawn.Tick () <0x002c8>
at Verse.TickList.Tick () <0x002c0>

Verse.Log:Error(String)
Verse.TickList:Tick()
Verse.TickManager:DoSingleTick()
Verse.TickManager:TickManagerUpdate()
Verse.Game:UpdatePlay()
Verse.Root_Play:Update()


[System.Linq]

Updated to 2017-7-8 v2. Fixed NPE when no cliques are around.

[gajop]

This mod crashes Rimworld for me soon after start.
Using just Core, HugsLib and this will cause a crash -> and no useful output in /tmp/rimworld_log

[System.Linq]

Updated to 2017-7-16. Fixed a minor bug where the message notifying you something had been stolen would display the count of the stolen goods as "x0" because the item had despawned with the thief.