Traders should respect techLevel to a maximum of the Spacer level

Started by AVE, October 03, 2016, 04:20:12 AM

Previous topic - Next topic

AVE

Currently all weapon traders (with the exception of neolithic traders) do not respect techLevel and thus can sell Ultra tech weapons that are not intended to be acquired by the player (they do not drop from mechanoid faction). While I see that this is circumvented by Tradeability:Never tag in weapon def, any new additions to the Ultra techlevel weapon pool without that tag can also be possibly sold by those weapon traders.

ItchyFlea

Which weapons do the traders sell that they shouldn't be selling to the player?
All my mods are licensed under a Attribution-NonCommercial-ShareAlike 4.0 International
Ask for permission before using in ModPacks

Click here for a list of the mods I've created

AVE

Quote from: ItchyFlea on October 05, 2016, 02:16:16 AM
Which weapons do the traders sell that they shouldn't be selling to the player?
Currently they don't sell any (due to Tradeability:Never is set for all mechanoid weapons in vanilla). I have created a modded weapon with techLevel:Ultra tag (for mechanoids) and forgot to add the Tradeability:Never. To much of my amusement the very first caravan from outlander faction in a test game presents this weapon to my colonists!. Then I started to dig into why this is possible and found that bug. It is really minor, but as a safety precaution the techLevel limits should be set for all traders, not only neolithic.

nccvoyager

Wouldn't this cause traders to be unable to buy/sell artifacts?

AVE

Quote from: nccvoyager on October 05, 2016, 05:22:42 PM
Wouldn't this cause traders to be unable to buy/sell artifacts?
Artifacts do not have techLevel at all.

ItchyFlea

This isn't a bug I'm afraid.
The techLevel tag is not meant to be used to restrict weapons with traders.
All my mods are licensed under a Attribution-NonCommercial-ShareAlike 4.0 International
Ask for permission before using in ModPacks

Click here for a list of the mods I've created