[1.0] Auto Seller - (v2.0.4.2) (13-12-2019)

Started by Supes, July 14, 2015, 05:03:35 PM

Previous topic - Next topic

lc-soz

I have a little issue that when I load a save some appeal item are reselected. In the images below it's possible to see two cases. But even though they are two different rules the same items are reselected (unselect every item in a test and thoses reappear after reload save):


  • Cowboy hat
  • Kevlar helmet
  • Power armor helmet
  • Psychic foil helmet
  • Tuque

My save have two rules with different item selected and still look like they interfere with each other.

In the images below the black spaces are for shrink image size

[attachment deleted by admin - too old]

Supes

#151
I believe I fixed the issue, it was an issue some loading checks. also added the unit value request, it's on the part of main rules,  Advanced rule support might come later





1.1.1.5
Fix for advanced rules not loading if in a subcategory of its parent
Added Maximum unit value check
Rule Config Dialog Gui Changes

Litcube

With the new version, I'm getting parser warnings. Sellvalue invalid, defaulting values.

Expected?

Supes


Litcube

Sweet.

Minor suggestion: The quality rule description should say "at [quality] and below", as opposed to "below [quality]".

Supes

good point, but I'll change it on the next update.  Don't want to spam steam workshop too much with patches :)

lc-soz

Quote from: Supes on October 15, 2016, 06:29:05 PM
I believe I fixed the issue, it was an issue some loading checks. also added the unit value request, it's on the part of main rules,  Advanced rule support might come later

1.1.1.5
Fix for advanced rules not loading if in a subcategory of its parent
Added Maximum unit value check
Rule Config Dialog Gui Changes

Thank you for the fix!  :)

Supes

Not done just yet, Support for Sell Value in Advanced Rules added, along with afew other changes/fixes







1.1.1.6
Various Gui glitches (Maintab, Rule Config)
Support for Sell Value in Advanced Rules
Translation Strings updated
Fix for Map Reroll 1.4.0 Conflict

lc-soz

Getting this error from time to time:



RWAutoSell.ASWorkGiver_PawnBargain provided target Thing_Human342163 but yielded no actual job for pawn Jade. The CanGiveJob and JobOnX methods may not be synchronized.


Supes

#159
ASWorkGiver_PawnBargain is to do with the caravan AI, and when it triggers the AI.

I'm presuming Trading AI is active (in Trading Behaviour), but let me know if you have it disabled, also let me know if any caravans were present at the time of the error, and if they were moving or hovering around your colony, in combat etc.

Edit: I've modified a big chunk of the work giver code, mainly because I had an epiphany on improving certain bits (curse me for having epiphanies), so it's turned from a bug fix into some improvements and optimisations as well.  I've tested around a season worth of in game time so far without any red text or sync errors appearing, and will be looking at improvements to the job it triggers itself (and again some more testing) before releasing the next update.  I Thought I'd let you guys know on my progress while you're waiting for the next update.

Litcube

#160
Curious if someone could shed some light on the following yellow debug message:

AutoSeller Parser Warning (LoadAdvanced): Advanced Rule Thing Category does not match Parent Rule Category, Advanced Rule not Loaded. - Line 998
AutoSeller Parser Warning (LoadAdvanced): Advanced Rule count doesn't match Loaded Advanced Rules - line 989

Here's the references config xml in question:

<Rule Type="Thing">
      <Category SubCats="False">FoodMeals</Category>
      <SellCount>0</SellCount>
      <SellValue>0</SellValue>
      <Quality>
        <Min>Awful</Min>
        <Max>Legendary</Max>
      </Quality>
      <Health>
        <Min>0</Min>
        <Max>1</Max>
      </Health>
      <ReorderPoint>0</ReorderPoint>
      <RestockLevel>0</RestockLevel>
      <Exceptions>
        <Advanced>
          <Thing>bakedpolenta</Thing>
          <SellCount>50</SellCount>
        </Advanced>
        <Advanced>
          <Thing>bowlstew</Thing>
          <SellCount>50</SellCount>
        </Advanced>
        <Advanced>
          <Thing>cheese</Thing>
          <SellCount>50</SellCount>
        </Advanced>
      </Exceptions>
    </Rule>





I'm asuming AutoSeller doesn't think that cheese is a meal?

Edit

I think it might have something to do with cheese's parent being category CookingSupplies, and inside the cheese def itself, it is a FoodMeal.

Supes

Which mod includes cheese?  I'll have a look at the mods ThingDefs XML's.

Litcube

Vegetable Garden.  I think it's a bug in their mod.  I fixed the issue by making cheese an "Ingredient" as opposed to an "Ingredient" and a "FoodMeal".

Litcube

#163
AutoSeller won't sell my Kevlar helmets.


<Rule Type="Thing">
      <Category SubCats="False">Headgear</Category>
      <SellCount>0</SellCount>
      <SellValue>0</SellValue>
      <Quality>
        <Min>Awful</Min>
        <Max>Legendary</Max>
      </Quality>
      <Health>
        <Min>0</Min>
        <Max>1</Max>
      </Health>
      <Thing>Apparel_KevlarHelmet</Thing>
      <ReorderPoint>0</ReorderPoint>
      <RestockLevel>0</RestockLevel>
    </Rule>


^That's my rule.  Will not sell them.  The helmets are showing in the trade list (are within orbital beacon range).

Other apparel (jackets, t-shirts, pants) sell fine.

Supes

that's a weird one, the helmets appear to be selling ok on my game with that rule.  I might need more info.

I might need a look at your full config file. also how many helmets do you have in storage, what's their stats (health and quality) on a couple of them will help me replicate the bug.